WIP: feat($compile): display line numbers for errors in the parser (#6338) #6764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/compiler/parser/html-parser.js
Outdated
| export function parseHTML (html, options) { | ||
| const stack = [] | ||
| const expectHTML = options.expectHTML | ||
| const isUnaryTag = options.isUnaryTag || no | ||
| const canBeLeftOpenTag = options.canBeLeftOpenTag || no | ||
| const lines = html.split(/\n/).map(x => x.length) |
There was a problem hiding this comment.
can I use /\r\n?|\n|\u2028|\u2029/ ....? 😃
Kingwl
force-pushed
the
new_dev
branch
2 times, most recently
from
e27e04d
to
f1e2684
Compare
Kingwl
changed the title
|
This is great! A few things to improve:
|
Kingwl
changed the title
13 tasks
|
Thanks for the great work on starting this - closing in favor of #7127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6338
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: